Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_picker_android] - will fix crash on Android 12+ devices #6691

Merged
merged 6 commits into from
May 10, 2024
Merged

[image_picker_android] - will fix crash on Android 12+ devices #6691

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
760455c
fix:: will fix crash on Android 12+ devices
Mairramer May 8, 2024
8d59828
added changelog
Mairramer May 8, 2024
995f0a7
fix
Mairramer May 8, 2024
2b12177
Merge branch 'main' into fix-image_picker-crash-android12+
Mairramer May 8, 2024
a2f4000
added test
Mairramer May 8, 2024
7114d5b
improve
Mairramer May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/image_picker/image_picker_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.8.12

* Fixes app crashes on Android 12+ caused by selected images with size 0.
Mairramer marked this conversation as resolved.
Show resolved Hide resolved

## 0.8.11

* Updates documentation to note that Android Photo Picker use is not optional on Android 13+.
Expand Down
9 changes: 6 additions & 3 deletions ...ker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ private void launchTakeVideoWithCameraIntent() {
} catch (ActivityNotFoundException e) {
try {
// If we can't delete the file again here, there's not really anything we can do about it.
//noinspection ResultOfMethodCallIgnored
// noinspection ResultOfMethodCallIgnored
videoFile.delete();
} catch (SecurityException exception) {
exception.printStackTrace();
Expand Down Expand Up @@ -515,7 +515,7 @@ private void launchTakeImageWithCameraIntent() {
} catch (ActivityNotFoundException e) {
try {
// If we can't delete the file again here, there's not really anything we can do about it.
//noinspection ResultOfMethodCallIgnored
// noinspection ResultOfMethodCallIgnored
imageFile.delete();
} catch (SecurityException exception) {
exception.printStackTrace();
Expand Down Expand Up @@ -692,7 +692,10 @@ private void handleChooseMediaResult(int resultCode, Intent intent) {
paths.add(new MediaPath(path, mimeType));
}
} else {
paths.add(new MediaPath(fileUtils.getPathFromUri(activity, intent.getData()), null));
Uri uri = intent.getData();
if (uri != null) {
paths.add(new MediaPath(fileUtils.getPathFromUri(activity, uri), null));
}
}
handleMediaResult(paths);
return;
Expand Down
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: image_picker_android
description: Android implementation of the image_picker plugin.
repository: https:/flutter/packages/tree/main/packages/image_picker/image_picker_android
issue_tracker: https:/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
version: 0.8.11
version: 0.8.12

environment:
sdk: ^3.3.0
Expand Down