Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Manual roll Flutter to c246ecd (84 revisions) + fixes #6863

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

ditman
Copy link
Member

@ditman ditman commented Jun 4, 2024

Updates the flutter master version and adds fixes for broken stuff.

  • [flutter_markdown] Updates a test image used as a golden file.
  • [google_maps_flutter_android] Flaky test/fixed OOB.

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
Copy link
Member Author

ditman commented Jun 4, 2024

(Brought from #6861)

OK, the android crash seems to be different/more explicit this time:

     FATAL EXCEPTION: GL-Map
Process: io.flutter.plugins.googlemapsexample, PID: 19653
java.lang.IllegalStateException: Trying to call onSurfaceCreated with no current context
	at m.fvx.l(:com.google.android.gms.policy_maps_core_dynamite@[email protected]:10)
	at m.ezu.run(:com.google.android.gms.policy_maps_core_dynamite@[email protected]:816)

This has taken me to the following public buganizer:

Maybe we can mitigate by doing this:

(/cc @reidbaker)

@reidbaker
Copy link
Contributor

(Brought from #6861)

OK, the android crash seems to be different/more explicit this time:

     FATAL EXCEPTION: GL-Map
Process: io.flutter.plugins.googlemapsexample, PID: 19653
java.lang.IllegalStateException: Trying to call onSurfaceCreated with no current context
	at m.fvx.l(:com.google.android.gms.policy_maps_core_dynamite@[email protected]:10)
	at m.ezu.run(:com.google.android.gms.policy_maps_core_dynamite@[email protected]:816)

This has taken me to the following public buganizer:

Maybe we can mitigate by doing this:

(/cc @reidbaker)

You resolved this. Did you find a solution?

@ditman
Copy link
Member Author

ditman commented Jun 4, 2024

You resolved this. Did you find a solution?

This resolved itself by bumping one more revision of Flutter, but the incoming changes don't seem related, so it's maybe an OOB fix from Google Maps or FTL (?) (or we got lucky in the flakiness lottery)

@ditman ditman requested a review from stuartmorgan June 4, 2024 20:20
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2024
Copy link
Contributor

auto-submit bot commented Jun 4, 2024

auto label is removed for flutter/packages/6863, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2024
@auto-submit auto-submit bot merged commit 84fd510 into flutter:main Jun 4, 2024
74 checks passed
@ditman
Copy link
Member Author

ditman commented Jun 4, 2024

Will restart the roller now that this has landed!

@ditman
Copy link
Member Author

ditman commented Jun 5, 2024

The new roll is now showing the "Trying to call onSurfaceCreated with no current context" error... Ugh!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 6, 2024
flutter/packages@11e192a...586faa6

2024-06-05 [email protected] [google_sign_in_web] Update button_tester to use web_only library. (flutter/packages#6868)
2024-06-05 [email protected] Roll Flutter from c246ecd to 27e0656 (17 revisions) (flutter/packages#6875)
2024-06-05 [email protected] [path_provider] Skip verifying sample file on macOS (flutter/packages#6874)
2024-06-05 [email protected] [google_maps_flutter] Custom marker size improvements (flutter/packages#4055)
2024-06-05 [email protected] [rfw] Material slider widget (flutter/packages#6610)
2024-06-04 [email protected] [ci] Manual roll Flutter to c246ecd (84 revisions) + fixes (flutter/packages#6863)
2024-06-04 [email protected] Correcting the typo of Flutter in projects (flutter/packages#6850)
2024-06-04 [email protected] [google_maps_flutter] Custom marker size improvements - platform impls (flutter/packages#6826)
2024-06-04 [email protected] Avoid cumbersome formatter workaround (flutter/packages#6573)
2024-06-04 [email protected] Clean Xcode project before analyzing and testing (flutter/packages#6842)
2024-06-03 [email protected] [pigeon] Kotlin/Java method overloading for the `setUp` method (flutter/packages#6843)
2024-06-03 [email protected] [url_launcher] Add support for setting show title on Chrome Custom Tabs (flutter/packages#6097)
2024-06-03 [email protected] Revert "Roll Flutter from c85fa6a to 7eebe29 (#6836)" (flutter/packages#6860)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https:/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
)

Updates the flutter master version and adds fixes for broken stuff.

* [flutter_markdown] Updates a test image used as a golden file.
* ~~[google_maps_flutter_android]~~ Flaky test/fixed OOB.

## Issues

* Completes flutter#6861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants