Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Manual roll Flutter to c246ecd (84 revisions) + fixes #6863

Merged
merged 8 commits into from
Jun 4, 2024
Merged

[ci] Manual roll Flutter to c246ecd (84 revisions) + fixes #6863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
571b862
Manual roll to c246ecd
ditman Jun 4, 2024
c49be3c
[flutter_markdown] Updates golden test file for gradient/antialias ch…
ditman Jun 4, 2024
0d70624
Merge branch 'main' into manual-roll-master-to-c246ecd
ditman Jun 4, 2024
b7505ff
Revert "[flutter_markdown] Updates golden test file for gradient/anti…
ditman Jun 4, 2024
1dfef50
Reapply "[flutter_markdown] Updates golden test file for gradient/ant…
ditman Jun 4, 2024
30ca290
Revert "Reapply "[flutter_markdown] Updates golden test file for grad…
ditman Jun 4, 2024
99223d9
Attempt to match different images in stable/master.
ditman Jun 4, 2024
bcfb628
Merge branch 'main' into manual-roll-master-to-c246ecd
ditman Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c85fa6abf4ffe253109bc5cac762e46d1853d325
c246ecdf8e8d564410698e86cc07e853269ebab8
Binary file modified ...ter_markdown/test/assets/images/golden/image_test/custom_builder_asset_logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...markdown/test/assets/images/golden/image_test/custom_builder_asset_logo_old.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/flutter_markdown/test/assets/images/golden/image_test/resource_asset_logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...utter_markdown/test/assets/images/golden/image_test/resource_asset_logo_old.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 8 additions & 4 deletions packages/flutter_markdown/test/image_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import 'package:flutter_test/flutter_test.dart';
import 'image_test_mocks.dart';
import 'utils.dart';

bool isRunningInStable = io.Platform.environment['CHANNEL'] == 'stable';

void main() => defineTests();

void defineTests() {
Expand Down Expand Up @@ -167,8 +169,9 @@ void defineTests() {

await expectLater(
find.byType(Container),
matchesGoldenFile(
'assets/images/golden/image_test/resource_asset_logo.png'));
matchesGoldenFile(isRunningInStable
? 'assets/images/golden/image_test/resource_asset_logo_old.png'
: 'assets/images/golden/image_test/resource_asset_logo.png'));
},
skip: kIsWeb, // Goldens are platform-specific.
);
Expand Down Expand Up @@ -413,8 +416,9 @@ void defineTests() {

await expectLater(
find.byType(Container),
matchesGoldenFile(
'assets/images/golden/image_test/custom_builder_asset_logo.png'));
matchesGoldenFile(isRunningInStable
? 'assets/images/golden/image_test/custom_builder_asset_logo_old.png'
: 'assets/images/golden/image_test/custom_builder_asset_logo.png'));
},
skip: kIsWeb, // Goldens are platform-specific.
);
Expand Down