Fixing #123 #124
Merged
Fixing #123 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMcMurder
commented
Oct 12, 2018
| @@ -272,7 +272,7 @@ exports.default = function (Component) { | |||
| }; | |||
|
|
|||
| WrappedComponent.defaultProps = { | |||
| innerRef: function innerRef() {}, | |||
| innerRef: null, | |||
There was a problem hiding this comment.
Fixes the build, which is currently broken here.
|
|
||
| const inputComponent = TestUtils.findRenderedComponentWithType(form, TestInput); | ||
| test.equal(inputComponent.isValid(), false); | ||
| test.equal(inputComponent.getErrorMessage(), 'Field is required'); |
There was a problem hiding this comment.
Without the above change this will fail
|
Looks good. |
hashwin
pushed a commit
to hashwin/formsy-react
that referenced
this pull request
Jun 12, 2019
* Fixing linting issues * Fixing issue where validationError wasn't appearing on when the field was required * Updating lib and release * Adding semicolons to fix lint issues * Slightly cleaner solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #123 and fixing the failing build.