-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing #123 #124
Merged
Merged
Fixing #123 #124
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3753070
Fixing linting issues
TheMcMurder 44b0563
Fixing issue where validationError wasn't appearing on when the field…
TheMcMurder 31b3313
Updating lib and release
TheMcMurder ad26cee
Adding semicolons to fix lint issues
TheMcMurder e046379
Slightly cleaner solution
TheMcMurder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -472,6 +472,30 @@ export default { | |
|
||
}, | ||
|
||
'should return the validationError if the field is invalid and required rule is true': function (test) { | ||
|
||
class TestForm extends React.Component { | ||
render() { | ||
return ( | ||
<Formsy> | ||
<TestInput name="A" | ||
validationError='Field is required' | ||
required | ||
/> | ||
</Formsy> | ||
); | ||
} | ||
} | ||
const form = TestUtils.renderIntoDocument(<TestForm/>); | ||
|
||
const inputComponent = TestUtils.findRenderedComponentWithType(form, TestInput); | ||
test.equal(inputComponent.isValid(), false); | ||
test.equal(inputComponent.getErrorMessage(), 'Field is required'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without the above change this will fail |
||
|
||
test.done(); | ||
|
||
}, | ||
|
||
'should handle objects and arrays as values': function (test) { | ||
|
||
class TestForm extends React.Component { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the build, which is currently broken here.