Adds position and velocity interfaces to FrankaHWSim #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
adds_position_velocity_interfaces_gazebo
branch
from
b45f582
to
2951585
Compare
This was referenced Aug 23, 2021
tahsinkose
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Giving a rogue review. Please do not push format changes unless they are required @rickstaa. They make finding the actual changes quite difficult and also create unnecessarily large diffs.
The rest LGTM. As I'm not a maintainer, my approval won't make a difference, but here it is as a goodwill gesture 😄
|
@tahsinkose Ah, thanks for pointing that out. I will rebase this commit, I forgot to disable the auto-format pre-commit pipeline for this one. I will perform a rebase to fix it. |
rickstaa
force-pushed
the
adds_position_velocity_interfaces_gazebo
branch
from
72a98c2
to
d352599
Compare
This was referenced Aug 26, 2021
rickstaa
force-pushed
the
adds_position_velocity_interfaces_gazebo
branch
from
d352599
to
345ae08
Compare
|
Please read #161 (comment) before merging #156. There I explain why I think this pull request is not the best solution. |
This commit adds the 'hardware_interface/PositionJointInterface' and 'hardware_interface/VelocityJointInterface' interfaces to the FrankaHWSim module. This was done to make the simulation closer match the real robot. Removes formatting changes
rickstaa
force-pushed
the
adds_position_velocity_interfaces_gazebo
branch
from
345ae08
to
253b31e
Compare
3 tasks
|
Closed since it is replaced by #181. |
marcbone
pushed a commit
that referenced
this pull request
Nov 22, 2021
…-7 to develop * commit '4f975048b82d85b2b8268ea56ebdfc0d8029a5ee': migrate to clang-tidy-7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the 'hardware_interface/PositionJointInterface' and 'hardware_interface/VelocityJointInterface' interfaces to the
FrankaHWSim module. This was done to make the simulation closer match the real robot.
Remarks