Process api hook #2131
Merged
Process api hook #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlythMeister
suggested changes
Oct 9, 2018
| let assemblies = assemblies |> Seq.toArray | ||
| let details = assemblies |> String.separated ", " | ||
| use __ = Trace.traceTask "NUnit" details | ||
| let p = createProcess setParams assemblies |
There was a problem hiding this comment.
could this not be
createProcess setParams assemblies
|> Proc.run
BlythMeister
previously approved these changes
Oct 9, 2018
Simplify command line when quotes are not required
matthid
commented
Oct 9, 2018
| @@ -11,14 +11,15 @@ let fsCheckConfig = { FsCheckConfig.defaultConfig with maxTest = 1000 } | |||
| [<Tests>] | |||
| let tests = | |||
| testList "Fake.Core.Process.Tests" [ | |||
| testPropertyWithConfig fsCheckConfig "toWindowsCommandLine is the inverse of fromWindowsCommandLine" <| | |||
| //Process.setEnableProcessTracing true | |||
There was a problem hiding this comment.
If this line is uncommented it completely breaks the "fake-context" for some reason and about the half (around 30) tests start to fail... Would be interesting to figure out why.
Note that not only tests in this file start failing but everywhere (especially the FakeVar and Context ones)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the new API in order to write unit-tests