Release 5.9 #2137
Release 5.9 #2137
Conversation
| [ | ||
| yield parameters.SubCommand |> string | ||
|
|
||
| if not (isNull parameters.ProjectFile) then |
There was a problem hiding this comment.
@magicmonty I noticed while writing the test that null leads to an ugly exception. Is this parameter required? Can we give a good default>
There was a problem hiding this comment.
@matthid
Which one gives an exception? The SubCommand or the ProjectFile?
Both are needed. For the SubCommand the default should be "generateall"
The Project file is needed and thus must not be null. This is the reason I added options on the SpecFlowNext variant
There was a problem hiding this comment.
Ok if it is needed can you please remove the nullcheck I added and make sure that user gets a proper error message if the parameter is not given?
There was a problem hiding this comment.
@matthid
I removed the null check and adjusted the API a bit. The ProjectFile now needs to be provided on "run". I have opened a new PR for this, as I cannot push to this branch
| [<Tests>] | ||
| let tests = | ||
| testList "Fake.DotNet.Testing.SpecFlow.Tests" [ | ||
| testCase "Test that new argument generation works" <| fun _ -> |
There was a problem hiding this comment.
@magicmonty Can you take a look at this test (if it is reasonably) and maybe add some to the other PRs as well?
There was a problem hiding this comment.
Do we need to run the specflow exe with mono when not on windows?
There was a problem hiding this comment.
Do we need to run the specflow exe with mono when not on windows?
I don't know. I suppose so.
There was a problem hiding this comment.
@magicmonty Can you take a look at this test (if it is reasonably) and maybe add some to the other PRs as well?
Sure, I have a look
There was a problem hiding this comment.
@matthid
I have updated the Tests in a new PR. However it seems I do something wrong with the Mono invocation. Can you give me a hint there?
Update Fake.Tools.Pickles
URGENT: Correct publish artifact
Fixes #2003
* Add message to the build state update * Update Fake.Tools.Pickles and added Unit tests * Fix Tests * Fix ArgumentHelper.checkIfMono * Made checkIfMono a bit more elegant * Correct publish artifact * Add `CreateProcess.disableTraceCommand` and use it to hide `appveyor.exe` calls. * print all stack traces in verbose mode, references #2136 * next time we can fix #2136 * add BlackFox.Fake.BuildTask to docs /cc @vbfox * Docs & cleanup * more docs * documentation
Seperate runInternal & handle error
Helper for update Build-Status
SpecFlowNextmodule toFake.DotNet.Testing.SpecFlowwith improved API and missing arguments - Fake.DotNet.Testing.SpecFlow: Added tests and optimized API #2143Fake.Testing.ReportGeneratorto includeClassFilterandFileFilter- Add class and file filter parameters to Fake.Testing.ReportGenerator #2120Fake.Tools.Picklesto include latest CLI additions - Update Fake.Tools.Pickles #2133appveyor.execalls - Release 5.9 #2137