Release 5.20.4

[matthid]

• ENHANCEMENT: Allow users of nunit3 set environment variables in the runner, thanks @robertpi - Allow users of nunit3 set environment variables in the runner #2543
• BUGFIX: Fix reportgenerator docs and compilation,thanks @matthid - ReportGenerator documentation example does work #2535
• BUGFIX: Fix Travis build, thanks @gdziadkiewicz - Fix Travis build #2549
• BUGIFX: Update Paket.Core to (better) support net5.0, thanks @pchinery - Update Paket.Core to (better) support net5.0 #2556
• BUGFIX: fix build by using Suave version to 2.5.6 in build script which is compatible with netstandard 2.0, thanks @yazeedobaid fix build and unit tests #2574
• ENHANCEMENT: Change NuGet feed APIs to use V3 of NuGet feed APIs, thanks @yazeedobaid fix build and unit tests #2574

[github-actions]

There has not been any activity in this pull request for the last 3 months so it will be closed in 14 days if there is no activity.

[dungpa]

Is there any chance to make a non-alpha release after 5.20.4-alpha.1642?

[yazeedobaid]

@matthid I have looked into the logs of Azure build and the problems are due to access permission on release\legacy\tools\cs\FSharp.Core.resources.dll and an error returned from this Azure task FAKE5_a2dadf20-1a83-4220-a4ee-b52f6c77f3cf\1.0.8\runFake5.js.

I have run the build locally from new changes on release/next branch using the following command, which is the one used on the Azure pipeline:
dotnet fake run build.fsx --parallel 3 -t Release_BuildAndTest
Also, I have set the BuildLegacy environment variable to true to be able to execute the legacy build.
For integration tests, I skipped them locally since they are slow to run but they should not affect the build since they ran successfully on the Azure build.

I got a successful build as shown in the following screenshot from the build report:

The Legacy_CreateNuGet target ran successfully and created the NuGet packages for legacy projects and no issue regarding access. During the local run I checked the release\legacy\tools\cs\FSharp.Core.resources.dll file and indeed it exists and the build process accessed it without problems.

For the issue related to executing an Azure task, I could not find the task to look into it. What I found is this repository vsts-fsharp. I'm not sure what is the relation between it and the Azure pipeline!

Also, what do the NuGet sources in Test_Extensions repository build scripts contain? I tried to access them but they seem to be private and need authorization.

[matthid]

I restarted the build and started one more with FAKE_DETAILED_ERRORS to get a stack trace (https://dev.azure.com/fakebuild/FSProjects/_build/results?buildId=1659&view=results). But I assume this isn't reproducible.

For the issue related to executing an Azure task, I could not find the task to look into it. What I found is this repository vsts-fsharp. I'm not sure what is the relation between it and the Azure pipeline!

Yes for the CI we use this task to run the build, all it does is download the FAKE-runner configured in the task (currently 5.20.1) and spin of the build (pretty much like manually downloading the portable.zip and running with an installed dotnet sdk). It will setup some Azure DevOps specifics like hidden variables, and Paket authentication against Azure DevOps NuGet Feeds, but those details should matter much. That should almost never affect the build process directly (or produce errors like the one we saw).

For the release-process we actually already dogfood ourself from the artefact built in the CI pipeline (basically extract that and run the release process from there)

Also, what do the NuGet sources in Test_Extensions repository build scripts contain? I tried to access them but they seem to be private and need authorization.

This is pretty much an artefact from debugging an issue - or rather to help understanding how azure DevOps NuGet feeds, access tokens and hidden variables work.

Actually, I think we are good to go for a release, now that everything is green. Please feel free to update the release notes and I can give it a shot (In worst case I need to update some Access tokens as I think there was a Mail about expiration, but we will see). Maybe I will try to release the current commit just to make sure.