Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.20.4 #2539

Merged
merged 24 commits into from
Mar 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9223c06
Release Notes
matthid Aug 5, 2020
f2d76ff
check if we can build with latest
matthid Aug 5, 2020
e9cc785
Allow users of nunit3 set environment variables in the runner
robertpi Aug 25, 2020
206ea55
Fix reportgenerator docs, fixes #2535
matthid Sep 3, 2020
c6d83f4
fix compilation
matthid Sep 3, 2020
c164ddb
Implement env vars for nunuit3 the using the same technique as fsi, D…
robertpi Sep 9, 2020
2e19bfb
fix copy / paste error
robertpi Sep 9, 2020
514bb27
Merge pull request #2543 from robertpi/add-support-for-env-var-to-nunit
matthid Sep 9, 2020
92aa26e
Update packages
matthid Oct 22, 2020
57e32a3
Try locking nuget versions
matthid Oct 22, 2020
2d29645
:/
matthid Oct 22, 2020
e8a0d64
downgrade fcs
matthid Oct 22, 2020
942abbc
Try to figure out what the problem is on gitlab
matthid Oct 22, 2020
cc9c2d6
Disable Greeting on PRs (never worked properly anyway)
matthid Oct 22, 2020
8dc82c3
Fix Travis build
gdziadkiewicz Oct 24, 2020
0b6b25f
Merge pull request #2549 from gdziadkiewicz/patch-1
matthid Oct 24, 2020
8de6d96
Update Paket.Core to support net5.0
pchinery Nov 18, 2020
5cda218
Merge pull request #2556 from pchinery/release/next
matthid Feb 19, 2021
18a43cf
fix build and unit tests
yazeedobaid Mar 23, 2021
d80958c
fix paket references for linux builds
yazeedobaid Mar 24, 2021
878e0fa
Update NuGet feed functionality to V3 of NuGet API
yazeedobaid Mar 26, 2021
493275d
Merge pull request #2574 from FoothillSolutions/fix-build-and-unit-tests
matthid Mar 27, 2021
0baaf8c
Add release notes for 5.20.4 release
yazeedobaid Mar 31, 2021
2f3f006
Merge pull request #2577 from FoothillSolutions/release-notes
matthid Mar 31, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/greetings.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Greetings

on: [pull_request, issues]
#on: [pull_request, issues]
on: [issues]

jobs:
greeting:
Expand All @@ -10,4 +11,4 @@ jobs:
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: 'Welcome to the FAKE community! Thank you so much for creating your first issue and therefore improving the project!'
pr-message: 'Welcome to the FAKE community! Thank you so much for directly helping to improve FAKE! You are now in good company and we hope this only the first in a long list of contributions :)'
#pr-message: 'Welcome to the FAKE community! Thank you so much for directly helping to improve FAKE! You are now in good company and we hope this only the first in a long list of contributions :)'
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
Thumbs.db
.DS_Store
#Ignore files build by Visual Studio
.fsdocs/
output/
docs/
docsBuild/
report/
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ language: csharp
sudo: required
dist: xenial # Ubuntu 16.04

dotnet: 3.1.100
dotnet: 3.1.201

addons:
apt:
Expand Down
9 changes: 9 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Release Notes

## 5.20.4 - 2021-03-31

* ENHANCEMENT: Allow users of nunit3 set environment variables in the runner, thanks @robertpi - https:/fsharp/FAKE/pull/2543
* BUGFIX: Fix reportgenerator docs and compilation,thanks @matthid - https:/fsharp/FAKE/issues/2535
* BUGFIX: Fix Travis build, thanks @gdziadkiewicz - https:/fsharp/FAKE/pull/2549
* BUGIFX: Update Paket.Core to (better) support net5.0, thanks @pchinery - https:/fsharp/FAKE/pull/2556
* BUGFIX: fix build by using Suave version to 2.5.6 in build script which is compatible with netstandard 2.0, thanks @yazeedobaid https:/fsharp/FAKE/pull/2574
* ENHANCEMENT: Change NuGet feed APIs to use V3 of NuGet feed APIs, thanks @yazeedobaid https:/fsharp/FAKE/pull/2574

## 5.20.3 - 2020-08-05

* BUGFIX: Fix unintentional unit return, thanks @objectx - https:/fsharp/FAKE/pull/2534
Expand Down
2 changes: 1 addition & 1 deletion build.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ nuget Fake.Windows.Chocolatey prerelease
nuget Fake.Tools.Git prerelease
nuget Mono.Cecil prerelease
nuget System.Reactive.Compatibility
nuget Suave
nuget Suave 2.5.6
nuget Newtonsoft.Json
nuget Octokit //"
#endif
Expand Down
18 changes: 4 additions & 14 deletions help/markdown/testing-reportgenerator.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,30 +19,20 @@ See https:/danielpalme/ReportGenerator
## Minimal working example

```fsharp
"#r "paket:
"#r paket:
nuget Fake.Core.Target
nuget Fake.Testing.ReportGenerator"

open Fake.Core
open Fake.Core.TargetOperators
open Fake.Testing

...

Target.create "Generate Reports" (fun _ ->
let parameters p = { p with TargetDir = "c:/reports/" }
!! "**/opencover.xml"
|> ReportGenerator.generateReports parameters
|> Seq.toList
|> ReportGenerator.generateReports (fun p -> { p with TargetDir = "c:/reports/" })
)

Target.create "Default" DoNothing

"Clean"
==> "SetAssemblyInfo"
==> "Build"
==> "RunCoverage"
==> "Generate Reports"
==> "Default"

Target.runOrDefault "Default"
Target.runOrDefault "Generate Reports"
```
18 changes: 12 additions & 6 deletions paket.dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version 5.249.0
version 5.251.0
content: none
//source C:\Users\matth\.nuget\localsource
source https://api.nuget.org/v3/index.json
Expand Down Expand Up @@ -27,8 +27,13 @@ nuget SSH.NET
nuget Microsoft.Web.Administration
nuget Mono.Web.Xdt
nuget Mono.Cecil prerelease
nuget Nuget.Core
nuget Nuget.Protocol
nuget NuGet.Core
nuget NuGet.Protocol < 5.7
nuget NuGet.Packaging < 5.7
nuget NuGet.Common < 5.7
nuget NuGet.Configuration < 5.7
nuget NuGet.Frameworks < 5.7
nuget NuGet.Versioning < 5.7
nuget FParsec
nuget bootstrap
nuget Knockout.Mapping
Expand Down Expand Up @@ -64,7 +69,7 @@ nuget FluentMigrator.Runner.SQLite
nuget FluentMigrator.Runner.SqlServer
nuget FluentMigrator.Runner.SqlServerCe
nuget HashLib
nuget FSharp.Compiler.Service content: none
nuget FSharp.Compiler.Service < 37 content: none
nuget Octokit
nuget System.Net.Http
nuget Microsoft.DotNet.PlatformAbstractions
Expand Down Expand Up @@ -113,7 +118,7 @@ group NetcoreBuild
nuget FSharp.Core
nuget Suave
nuget System.AppContext prerelease
nuget Paket.Core prerelease
nuget Paket.Core // prerelease
nuget Fake.Api.GitHub prerelease // FAKE_VERSION (don't edit this line)
nuget Fake.Core.Target prerelease // FAKE_VERSION (don't edit this line)
nuget Fake.Core.SemVer prerelease // FAKE_VERSION (don't edit this line)
Expand Down Expand Up @@ -180,7 +185,8 @@ group netcore
nuget Octokit
nuget Newtonsoft.Json
nuget Paket.Core // prerelease
nuget NuGet.Protocol
nuget NuGet.Protocol < 5.7
nuget NuGet.Packaging < 5.7
nuget Mono.Cecil prerelease
nuget Mono.Posix.NETStandard
nuget FSharp.Control.Reactive
Expand Down
Loading