Fixed weakref async credential close when self.credential is None #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #328 included a weakref to close async credential, to avoid the Unclosed Client Session warning.
This PR aims to fix the case that we can have self.credential = None after passing the self.do_connect.
Lines 470-471 of spec.py is the fix:
https:/gabrieldaiha/adlfs/blob/d2a5be68af7934025f884d2dc523f1708738c6d7/adlfs/spec.py#L470-L471