Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document that credential needs to be from azure.identity.aio #463

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

temporaer
Copy link
Contributor

@temporaer temporaer commented Mar 13, 2024

if it's a sync credential, then the weakref.finalize callback will cause an error, close() -> None cannot be awaited.

if it's a sync credential, then the weakref.finalize call will
cause an error, close() -> None cannot be awaited.
@temporaer
Copy link
Contributor Author

(There's a chance that this addresses the same issue as #330, though on the user side.)

adlfs/spec.py Outdated Show resolved Hide resolved
adlfs/spec.py Outdated Show resolved Hide resolved
@TomAugspurger TomAugspurger merged commit 777a8d5 into fsspec:main Apr 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants