Add option to keep metadata in files processed by gatsby-plugin-sharp
#10210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
suggested changes
Nov 29, 2018
… check for false. Co-Authored-By: FineWolf <[email protected]>
|
Changes have been made as requested. (cc. @DSchau ) |
|
Made a quick change to ensure that our setting is passed on to Pngquant when running imagemin. |
|
@DSchau any news on this PR? Right now I'm relying on a fork for my builds. |
|
@FineWolf thanks for the ping. I'll give this another once over, and probably get it merged in. Thanks for your patience! |
DSchau
approved these changes
Dec 7, 2018
|
Holy buckets, @FineWolf — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
|
Successfully published: |
m-allanson
added a commit
that referenced
this pull request
Dec 8, 2018
* master: (1421 commits) feat(gatsby-image): add onStartLoad prop (#6702) fix(docs): add Ecosystem to docs sidebar, consistency with tutorial sidebar (#10350) fix(www): Starters.yaml housekeeping (#10354) docs: add ttag starter (#10352) docs: document branching (#9983) plugin checker initial commit (#7062) docs: new starter features is required (#10353) docs: migrated line highlighting to highlight-line, highlight-start, highlight-end (#10202) Add Birra Napoli to site showcase (#10344) Add BetterDocs to site showcase (#10349) chore(release): Publish Add option to keep metadata in files processed by `gatsby-plugin-sharp` (#10210) fix(gatsby): [loki] sync db autosaves (#10212) Add Ad Hoc Homework to sites.yml (#10346) fix(graphql-skip-limit): declare `graphql` peer dependency (#10305) fix(gatsby-plugin-offline): gracefully degrade if appshell isn't precached (#10329) Service workers note (#10276) fix(docs): link fixes, podcast addition (#10332) feat(docs): Create clearer pathways in docs (#9898) feat(www): Rename community section to creators (#10312) ...
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…p` (gatsbyjs#10210) * Add option to keep metadata in files processed by `gatsby-plugin-sharp` * Since pluginOptions are strictly type-checked, no need for the strict check for false. Co-Authored-By: FineWolf <[email protected]> * Changed README.md and index.js based on recommendations from @DSchau * Spelling corrections in README.md * Fixed Pngquant not respecting the stripMetadata option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Done
gatsby-plugin-sharp. The old behavior remains as default.gatsby-plugin-sharpwas one of the only plugins who didn't support passing configuration thrugatsby-config.js. The only way to enable MozJpeg was via an environment variable. This also has been normalized while maintaining old behavior as default.Reasoning
I'm currently rebuilding my website with
gatsby. While I was working on my portfolio section, I noticed that many of my pictures were rendering differently in Firefox vs Chrome due to the lack of ICC profile attached to the image (untagged images in most browsers render using the Monitor's RGB profile; Chrome seems to assume the pictures are using sRGB IEC61966-2.1). Also, I tend to like to keep my Copyright EXIF information on my images.This PR (with no breaking changes to old behavior) allows us to specify if we want to strip metadata in the images or not.