Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-sharp): make default image quality option configurable #9967

Conversation

ivanicharts
Copy link

@ivanicharts ivanicharts commented Nov 16, 2018

resolve #4873

@pieh
Copy link
Contributor

pieh commented Nov 16, 2018

Hey, did you see #7548 ? It was using same approach but this not enough, as it won't apply to other uses of gatsby-plugin-sharp other than gatsby-transformer-sharp

@ivanicharts
Copy link
Author

@pieh sorry, missed it

@pieh
Copy link
Contributor

pieh commented Dec 7, 2018

Note worthy - #10210 sets up foundation to set default quality setting via plugin options for gatsby-plugin-sharp

@DSchau DSchau changed the title Topic | 4873 | make default image quality option configurable feat(gatsby-plugin-sharp): make default image quality option configurable Dec 7, 2018
@LekoArts
Copy link
Contributor

LekoArts commented Jan 9, 2019

Hi @ivanicharts 👋 Since #10210 is merged you could rebase your fork onto master and work of that base.

@LekoArts LekoArts added the status: awaiting author response Additional information has been requested from the author label Jan 10, 2019
@wardpeet
Copy link
Contributor

Thanks so much for the PR!

Unfortunately, we're not going to merge this at this time. We don't set a defaultQuality anymore in transformer sharp, it's handled by sharp-plugin.

As such--we're going to close this out. We want you to know that we certainly want to keep you as a contributor to Gatsby, so we'd encourage you to check out our open issues.

Thanks again, and we look forward to seeing more PRs from you in the future! 💪 💜

@wardpeet wardpeet closed this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to configure default image quality for ImageSharp queries
4 participants