Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to configure default image quality #7548

Conversation

DSchau
Copy link
Contributor

@DSchau DSchau commented Aug 22, 2018

Fixes #4873

Don't love exporting the __DEFAULT_QUALITY__, but hey it works and makes it testable, so that's a win.

@pieh
Copy link
Contributor

pieh commented Aug 28, 2018

Nice! People actually really want that, so only nitpicky comment here is to add defaultQuality to resize transform

and this is good to go

@KyleAMathews
Copy link
Contributor

Hmm this still isn't global unfortunately as it only affects transformer-sharp and not remark-images or other plugins using plugin-sharp.

@pieh
Copy link
Contributor

pieh commented Aug 29, 2018

Hmm this still isn't global unfortunately as it only affects transformer-sharp and not remark-images or other plugins using plugin-sharp.

Given that gatsby-plugin-sharp isn't really gatsby plugin, but an utility library, to add this there, we would need to store default quality in some global state (either plugin or gatsby managed - cache util?). And also remove any graphql defaultValue as it will always override things

@DSchau
Copy link
Contributor Author

DSchau commented Sep 4, 2018

Don't know how I missed these comments (maybe an e-mail filter or something) but I'll take a look at improving this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants