Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-sharp): make default image quality option configurable #9967

Closed
wants to merge 1 commit into from
Closed

feat(gatsby-plugin-sharp): make default image quality option configurable #9967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 34 additions & 33 deletions packages/gatsby-transformer-sharp/src/extend-node-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,10 @@ const getTracedSVG = async ({ file, image, fieldArgs }) =>
fileArgs: fieldArgs,
})

const fixedNodeType = ({
type,
pathPrefix,
getNodeAndSavePathDependency,
reporter,
name,
cache,
}) => {
const fixedNodeType = (
{ type, pathPrefix, getNodeAndSavePathDependency, reporter, name, cache },
{ defaultQuality = 50 }
) => {
return {
type: new GraphQLObjectType({
name: name,
Expand Down Expand Up @@ -131,7 +127,7 @@ const fixedNodeType = ({
},
quality: {
type: GraphQLInt,
defaultValue: 50,
defaultValue: defaultQuality,
},
toFormat: {
type: ImageFormatType,
Expand Down Expand Up @@ -167,14 +163,10 @@ const fixedNodeType = ({
}
}

const fluidNodeType = ({
type,
pathPrefix,
getNodeAndSavePathDependency,
reporter,
name,
cache,
}) => {
const fluidNodeType = (
{ type, pathPrefix, getNodeAndSavePathDependency, reporter, name, cache },
{ defaultQuality = 50 }
) => {
return {
type: new GraphQLObjectType({
name: name,
Expand Down Expand Up @@ -253,7 +245,7 @@ const fluidNodeType = ({
},
quality: {
type: GraphQLInt,
defaultValue: 50,
defaultValue: defaultQuality,
},
toFormat: {
type: ImageFormatType,
Expand Down Expand Up @@ -298,13 +290,10 @@ const fluidNodeType = ({
}
}

module.exports = ({
type,
pathPrefix,
getNodeAndSavePathDependency,
reporter,
cache,
}) => {
module.exports = (
{ type, pathPrefix, getNodeAndSavePathDependency, reporter, cache },
pluginOptions
) => {
if (type.name !== `ImageSharp`) {
return {}
}
Expand All @@ -318,15 +307,27 @@ module.exports = ({
}

// TODO: Remove resolutionsNode and sizesNode for Gatsby v3
const fixedNode = fixedNodeType({ name: `ImageSharpFixed`, ...nodeOptions })
const resolutionsNode = fixedNodeType({
name: `ImageSharpResolutions`,
...nodeOptions,
})
const fixedNode = fixedNodeType(
{ name: `ImageSharpFixed`, ...nodeOptions },
pluginOptions
)
const resolutionsNode = fixedNodeType(
{
name: `ImageSharpResolutions`,
...nodeOptions,
},
pluginOptions
)
resolutionsNode.deprecationReason = `Resolutions was deprecated in Gatsby v2. It's been renamed to "fixed" https://example.com/write-docs-and-fix-this-example-link`

const fluidNode = fluidNodeType({ name: `ImageSharpFluid`, ...nodeOptions })
const sizesNode = fluidNodeType({ name: `ImageSharpSizes`, ...nodeOptions })
const fluidNode = fluidNodeType(
{ name: `ImageSharpFluid`, ...nodeOptions },
pluginOptions
)
const sizesNode = fluidNodeType(
{ name: `ImageSharpSizes`, ...nodeOptions },
pluginOptions
)
sizesNode.deprecationReason = `Sizes was deprecated in Gatsby v2. It's been renamed to "fluid" https://example.com/write-docs-and-fix-this-example-link`

return {
Expand Down Expand Up @@ -403,7 +404,7 @@ module.exports = ({
},
quality: {
type: GraphQLInt,
defaultValue: 50,
defaultValue: pluginOptions.defaultQuality || 50,
},
jpegProgressive: {
type: GraphQLBoolean,
Expand Down