-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPE #7
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Not sure if I understand what are these files designed for. As a first sight they should be included in the corresponding |
I'm not sure either. I think they're just artefacts of how we're using |
each component creates the dartsim folder has two components defined: on is for the headers it installs, and the other is for the plugin |
Ah that's what I was missing, @scpeters . I see includes for both components though, maybe the
I guess since TPE-plugin is not installing any headers, we could get rid of the I'm not sure what that may break through, because the And the components in |
The dartsim-plugin Export.hh files just define visibility symbols, which shouldn't be needed for a plugin. I think our debbuilder job will be marked as unstable if there are uninstalled files. Maybe we want to be able to tell ign-cmake to disable generation of these headers? They are currently only disabled for
I need to double-check what the If you rename the root folder to |
+1, yeah I agree we don't need to install these auto-generated headers for tpe plugin as well. Looks like the |
To avoid warnings on unwanted files to be installed, we can use the |
Signed-off-by: Louise Poubel <[email protected]>
Ok, for now I just followed what DART is doing and included it in |
Testing this branch in a custom job not to upload anything: https://build.osrfoundation.org/job/_test_ign-physics2-debbuilder/ |
I tried to build 2.1.0 with this branch and the software is not installing
|
Solved the problems with engine paths https://build.osrfoundation.org/job/_test_ign-physics2-debbuilder/5/ |
Closes #5
These are the files I see on my colcon workspace:
Installed TPE files
There are 2 main libraries:
tpe-plugin
tpelib
Some files seem not to belong to either though:
install/lib/cmake/ignition-physics2-tpe/*
install/lib/pkgconfig/ignition-physics2-tpe.pc
So I haven't included them anywhere. I think
dartsim
is including the equivalent files on its side though. Maybe these should be added totpe-plugin
?