Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TPE codecheck errors #62

Merged
merged 3 commits into from
Jun 1, 2020
Merged

Conversation

claireyywang
Copy link
Contributor

@claireyywang claireyywang commented May 29, 2020

Add tpe to codecheck and fix errors. Remove white spaces and shorten line length. Closes #58

Uses sh tools/code_check.sh to conduct code check on tpe

Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
@claireyywang claireyywang added 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 29, 2020
@claireyywang claireyywang requested a review from iche033 May 29, 2020 18:58
@claireyywang claireyywang requested a review from mxgrey as a code owner May 29, 2020 18:58
@claireyywang claireyywang self-assigned this May 29, 2020
@claireyywang claireyywang removed the request for review from mxgrey May 29, 2020 18:58
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #62 into ign-physics2 will increase coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics2      #62      +/-   ##
================================================
+ Coverage         81.52%   81.53%   +0.01%     
================================================
  Files               103      103              
  Lines              3432     3434       +2     
================================================
+ Hits               2798     2800       +2     
  Misses              634      634              
Impacted Files Coverage Δ
tpe/lib/src/Engine.hh 100.00% <ø> (ø)
tpe/lib/src/Link.hh 100.00% <ø> (ø)
tpe/lib/src/Model.hh 100.00% <ø> (ø)
tpe/lib/src/Shape.hh 100.00% <ø> (ø)
tpe/lib/src/World.hh 100.00% <ø> (ø)
tpe/plugin/src/Base.hh 98.00% <ø> (ø)
tpe/plugin/src/SDFFeatures.cc 84.41% <ø> (ø)
tpe/plugin/src/ShapeFeatures.cc 64.34% <ø> (ø)
tpe/plugin/src/SimulationFeatures.cc 39.13% <ø> (ø)
tpe/plugin/src/EntityManagementFeatures.cc 78.23% <75.00%> (+0.12%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f99de...d8099e0. Read the comment docs.

@chapulina
Copy link
Contributor

chapulina commented May 29, 2020

There are still some codecheck errors on Jenkins:

https://build.osrfoundation.org/job/ignition_physics-ci-pr_any-ubuntu_auto-amd64/684/cppcheckResult/

Those are checked running make codecheck. If you're in a colcon workspace: Actually, Jenkins is running tools/code_check.sh, see gazebo-tooling/release-tools#148

colcon build --cmake-target codecheck --packages-select-regex .*physics

@iche033
Copy link
Contributor

iche033 commented May 29, 2020

I see the same code check errors running sh tools/code_check.sh.

make codecheck gives a couple of errors related to to tpe:

/usr/bin/find: ‘/home/osrf/code/ign_c_ws/src/ign-physics/tpe/include’: No such file or directory

Not sure if something that could be fixed in ign-physics or we have to modify ign-cmake. We don't install any headers and the directory layout is different so that msg does not apply. We could just ignore it.

@chapulina
Copy link
Contributor

We don't install any headers

TIL that ign-cmake installs some for us, see gazebo-release/gz-physics2-release#7 (comment)

@iche033
Copy link
Contributor

iche033 commented May 29, 2020

ah yes the auto-generated headers..

@chapulina chapulina added the TPE Trivial Physics Engine label Jun 1, 2020
Signed-off-by: claireyywang <[email protected]>
@claireyywang
Copy link
Contributor Author

I have fixed the warning. Ready for another review @iche033 🙇‍♀️

@claireyywang claireyywang merged commit 09773fb into ign-physics2 Jun 1, 2020
@claireyywang claireyywang deleted the claire/tpe-codecheck branch June 1, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome TPE Trivial Physics Engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants