Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make codecheck on ubuntu #148

Open
osrf-migration opened this issue Feb 28, 2019 · 1 comment
Open

Use make codecheck on ubuntu #148

osrf-migration opened this issue Feb 28, 2019 · 1 comment
Labels
buildfarm enhancement New feature or request major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Libraries using ign-cmake can use make codecheck to run cppcheck, but older libraries still rely on tools/code_check.sh. For that reason, Jenkins still uses code_check.sh, so even the new libraries need to have that script.

It would be good to use make codecheck for the libraries that support it, so that we can remove the custom script from them. This is becoming more pressing as the cppcheck results start to diverge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildfarm enhancement New feature or request major
Projects
None yet
Development

No branches or pull requests

2 participants