Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows colcon: Rename ignition package to gz if not in ws #754

Merged
merged 9 commits into from
Jun 25, 2022

Conversation

chapulina
Copy link
Contributor

We need to support Citadel and Fortress ignition- packages, as well as Garden gz- packages.

The logic here checks if colcon can detect the ignition- package in the workspace, and if it can't, it renames the package to gz- and tries that.

Test runs:

# BEGIN SECTION: Update package ignition-utils2 from ignition to gz if needed
Packages in workspace:
gz-cmake3
gz-utils2

gz-utils2
Using package name gz-utils2
# END SECTION
# BEGIN SECTION: Update package ignition-utils1 from ignition to gz if needed
Packages in workspace:

ignition-cmake2
ignition-utils1
ignition-utils1
ignition-utils1
Using package name ignition-utils1
# END SECTION

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@methylDragon methylDragon merged commit 7f052cf into master Jun 25, 2022
@methylDragon methylDragon deleted the chapulina/colcon_gz_win branch June 25, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants