Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CMake project to gz #57

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Rename CMake project to gz #57

merged 3 commits into from
Jun 25, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented May 3, 2022 •
edited
Loading

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 3, 2022
@chapulina chapulina requested a review from azeey as a code owner May 3, 2022 19:26
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 3, 2022
@chapulina chapulina added needs upstream release Blocked by a release of an upstream library and removed 🌱 garden Ignition Garden labels May 3, 2022
@chapulina chapulina mentioned this pull request May 3, 2022
Closed
17 tasks
@chapulina chapulina marked this pull request as draft May 3, 2022 19:34
@chapulina chapulina mentioned this pull request May 3, 2022
Merged
@scpeters scpeters mentioned this pull request May 3, 2022
Merged
9 tasks
@chapulina chapulina mentioned this pull request May 4, 2022
Closed
@chapulina chapulina mentioned this pull request May 9, 2022
Merged
@chapulina chapulina mentioned this pull request Jun 8, 2022
Merged
@chapulina chapulina marked this pull request as ready for review June 16, 2022 17:31
@chapulina @methylDragon
Rename CMake project to gz
0aa3cc7 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina @methylDragon
Bazel
1c86eff 
Signed-off-by: Louise Poubel <[email protected]>
@scpeters scpeters mentioned this pull request Jun 21, 2022
Closed
methylDragon
methylDragon approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about that bazel change though

@chapulina
Copy link
Contributor Author

I'm unsure about that bazel change though

I've been changing whatever seems reasonable, and I believe @mjcarroll will do a pass over all libs after we're done to fix any remaining Bazel issues.

@chapulina chapulina mentioned this pull request Jun 25, 2022
Merged
@codecov
Copy link

codecov bot commented Jun 25, 2022 •
edited
Loading

Codecov Report

Merging #57 (4658153) into main (3463812) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files          17       17           
  Lines        2334     2334           
=======================================
  Hits          958      958           
  Misses       1376     1376

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3463812...4658153. Read the comment docs.

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 25, 2022
@chapulina chapulina enabled auto-merge (squash) June 25, 2022 18:07
@chapulina chapulina merged commit 99acf96 into main Jun 25, 2022
@chapulina chapulina deleted the gz_cmake_project branch June 25, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @methylDragon