Fix deprecation warning from new ffmpeg #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #415 Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/fix_av_deprecation
branch
from
a1a3dee
to
19b0b29
Compare
Codecov Report
@@ Coverage Diff @@
## gz-common5 #416 +/- ##
===========================================
Coverage 80.38% 80.38%
===========================================
Files 85 85
Lines 9944 9944
===========================================
Hits 7993 7993
Misses 1951 1951
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #415
This bit of code is already protected by LIBAVFORMAT_VERSION_MAJOR >= 59, which had the
ch_layout.nb_channelsthat is recommended to be used by their API: https:/FFmpeg/FFmpeg/blob/d931554f668186729bf290ed9afa6e9a4417328b/libavcodec/avcodec.h#L1009-L1016Signed-off-by: Michael Carroll [email protected]