Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PIMPL for GUI Events in Fortress #239

Closed
scpeters opened this issue Jun 22, 2021 · 1 comment
Closed

Use PIMPL for GUI Events in Fortress #239

scpeters opened this issue Jun 22, 2021 · 1 comment
Assignees
@scpeters
Labels
enhancement New feature or request 🏯 fortress Ignition Fortress

Comments

@scpeters
Copy link
Member

Desired behavior

I noticed some fields that would be nice to add to the *ClickToScene events in #209 (comment), but this breaks ABI since we aren't using the PIMPL pattern.

So, we should use PIMPL in this header and move the implementations to a src/GuiEvents.cc file.

Alternatives considered

Keep it as is and only add new fields in unreleased code. This is less flexible.

Implementation suggestion

See src/Application.cc for an example.

Additional context

https://en.cppreference.com/w/cpp/language/pimpl
@scpeters scpeters added enhancement New feature or request 🏯 fortress Ignition Fortress labels Jun 22, 2021
@scpeters scpeters self-assigned this Jun 22, 2021
@chapulina chapulina mentioned this issue Jun 23, 2021
Merged
8 tasks
@scpeters
Copy link
Member Author

done in #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scpeters scpeters

Labels
enhancement New feature or request 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scpeters