Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMPL GUI events #253

Merged
merged 3 commits into from
Jul 16, 2021
Merged

PIMPL GUI events #253

merged 3 commits into from
Jul 16, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 16, 2021

Signed-off-by: ahcorde [email protected]

🎉 Enhancement

Summary

PIMPL GUI events. @scpeters let me know if you target a specific ign-gui version.

Checklist

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde requested a review from scpeters July 16, 2021 08:41
@ahcorde ahcorde self-assigned this Jul 16, 2021
@ahcorde ahcorde requested a review from jennuine as a code owner July 16, 2021 08:41
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #253 (59e1d0f) into main (1190ed0) will increase coverage by 3.75%.
The diff coverage is 56.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   61.57%   65.32%   +3.75%     
==========================================
  Files          21       27       +6     
  Lines        2803     3989    +1186     
==========================================
+ Hits         1726     2606     +880     
- Misses       1077     1383     +306     
Impacted Files Coverage Δ
include/ignition/gui/GuiEvents.hh 100.00% <ø> (ø)
src/Conversions.cc 100.00% <ø> (ø)
src/plugins/image_display/ImageDisplay.cc 30.32% <0.00%> (+7.05%) ⬆️
src/Plugin.cc 57.44% <17.64%> (-2.83%) ⬇️
src/plugins/screenshot/Screenshot.cc 33.33% <33.33%> (ø)
src/plugins/minimal_scene/MinimalScene.cc 51.70% <51.70%> (ø)
...s/transport_scene_manager/TransportSceneManager.cc 52.29% <52.29%> (ø)
src/plugins/camera_tracking/CameraTracking.cc 68.45% <68.45%> (ø)
src/plugins/scene3d/Scene3D.cc 48.89% <71.51%> (+36.11%) ⬆️
src/Application.cc 84.89% <100.00%> (+0.20%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f107bd1...59e1d0f. Read the comment docs.

@scpeters
Copy link
Member

@scpeters let me know if you target a specific ign-gui version.

this breaks ABI, so it has to go to main

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@chapulina chapulina merged commit 07c69de into main Jul 16, 2021
@chapulina chapulina deleted the ahcorde/pimpl_gui_events branch July 16, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants