Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ign instead of using cmake module to check for ignition-tools #240

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

j-rivero
Copy link
Contributor

Part of gazebo-tooling/release-tools#472

I don't detect the conditional installation of the ign submodule, the PR just
changed the way of detecting ign for testing.

@j-rivero j-rivero requested a review from jennuine as a code owner June 23, 2021 15:29
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #240 (764250d) into ign-gui3 (3df3ad6) will increase coverage by 51.13%.
The diff coverage is 59.81%.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-gui3     #240       +/-   ##
=============================================
+ Coverage     14.55%   65.68%   +51.13%     
=============================================
  Files            13       23       +10     
  Lines          1333     2827     +1494     
=============================================
+ Hits            194     1857     +1663     
+ Misses         1139      970      -169     
Impacted Files Coverage Δ
include/ignition/gui/Helpers.hh 100.00% <ø> (+100.00%) ⬆️
include/ignition/gui/Plugin.hh 100.00% <ø> (+100.00%) ⬆️
src/ign.cc 37.83% <ø> (+37.83%) ⬆️
src/plugins/grid_3d/Grid3D.cc 28.57% <0.00%> (ø)
src/plugins/image_display/ImageDisplay.cc 23.27% <ø> (ø)
src/plugins/publisher/Publisher.cc 90.78% <ø> (ø)
src/Plugin.cc 57.44% <22.22%> (+57.44%) ⬆️
src/plugins/screenshot/Screenshot.cc 33.33% <33.33%> (ø)
src/plugins/scene3d/Scene3D.cc 42.38% <41.86%> (ø)
src/plugins/key_publisher/KeyPublisher.cc 56.52% <56.52%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d31cd...764250d. Read the comment docs.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chapulina chapulina merged commit e55a1a2 into ign-gui3 Jun 23, 2021
@chapulina chapulina deleted the igntools_cmake_removal_3 branch June 23, 2021 19:21
@chapulina chapulina mentioned this pull request Jun 14, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants