Don't set visual scale for point markers #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
This was referenced Nov 25, 2021
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #321 +/- ##
============================================
+ Coverage 65.63% 65.75% +0.11%
============================================
Files 32 34 +2
Lines 4723 4754 +31
============================================
+ Hits 3100 3126 +26
- Misses 1623 1628 +5
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Nov 25, 2021
chapulina
added a commit
that referenced
this pull request
Dec 8, 2021
* Added log storing for ign-gui (#272) Signed-off-by: Nikhil Nair <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Don't crash if a plugin has invalid QML (#315) Signed-off-by: Louise Poubel <[email protected]> * Set marker point size from message (#317) Signed-off-by: Louise Poubel <[email protected]> * Don't set visual scale for point markers (#321) Signed-off-by: Louise Poubel <[email protected]> * Fix TopicEcho plugin message display (#322) - Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <[email protected]> * Use qmldir to define QML module with IgnSpinBox (#319) Signed-off-by: William Wedler <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Add PreRender event to MinimalScene (#325) Signed-off-by: Louise Poubel <[email protected]> * Offer a way to disable warnings on marker manager (#326) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> * Fix codecheck (#329) Signed-off-by: Louise Poubel <[email protected]> * Fix codecheck (#332) Signed-off-by: Louise Poubel <[email protected]> * Grid config: set values from startup and improve layout (#324) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nikhil Nair <[email protected]> Co-authored-by: Rhys Mainwaring <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This is a follow up to #317. The scale is currently being applied to the entire visual, so points end up further apart as we increase it. I'm not sure if this is a use case that anyone would rely on. My suggestion is to skip setting the visual scale for points, and use the scale just for point size.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸