-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix message display in TopicEcho #322
Fix message display in TopicEcho #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should target ign-gui3
, @chapulina ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, works for me. Would you be able to retarget the PR to ign-gui3
(Citadel), and then we'll merge forward? Thanks!
- Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <[email protected]>
eef0937
to
734b856
Compare
I've changed the base branch to |
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #322 +/- ##
============================================
- Coverage 66.80% 66.73% -0.07%
============================================
Files 25 25
Lines 2961 2961
============================================
- Hits 1978 1976 -2
- Misses 983 985 +2
Continue to review full report at Codecov.
|
* Added log storing for ign-gui (#272) Signed-off-by: Nikhil Nair <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Don't crash if a plugin has invalid QML (#315) Signed-off-by: Louise Poubel <[email protected]> * Set marker point size from message (#317) Signed-off-by: Louise Poubel <[email protected]> * Don't set visual scale for point markers (#321) Signed-off-by: Louise Poubel <[email protected]> * Fix TopicEcho plugin message display (#322) - Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <[email protected]> * Use qmldir to define QML module with IgnSpinBox (#319) Signed-off-by: William Wedler <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Add PreRender event to MinimalScene (#325) Signed-off-by: Louise Poubel <[email protected]> * Offer a way to disable warnings on marker manager (#326) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> * Fix codecheck (#329) Signed-off-by: Louise Poubel <[email protected]> * Fix codecheck (#332) Signed-off-by: Louise Poubel <[email protected]> * Grid config: set values from startup and improve layout (#324) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nikhil Nair <[email protected]> Co-authored-by: Rhys Mainwaring <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🦟 Bug fix
Summary
This PR fixes a problem with the TopicEcho plugin where the message is not displayed correctly.
This may be apparent on macOS because of the Qt version installed using homebrew (details below).
width
property in ListView delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15)model.display
(see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview)System
OS: macOS Big Sur 11.6.4
Qt version: 5.15.2
Before
The messages are not displayed correctly and a warning is printed to the terminal.
After
The messages display as expected and there is no warning.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge