-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Snackbar qtquick object #369
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #369 +/- ##
============================================
- Coverage 65.96% 65.83% -0.14%
============================================
Files 29 29
Lines 3191 3202 +11
============================================
+ Hits 2105 2108 +3
- Misses 1086 1094 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to the centralized approach using a signal from the MainWindow
👍 This should make it easier to improve the snackbar in the future. For example, in the future, if we start getting too many notifications at once, we may want to implement some logic to display them consecutively.
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
https:/ignitionrobotics/ign-gui into ahcorde/3/snackbar
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
🎉 New feature
Summary
Create a IgnSnackBar QtQuick object to show message to the user in the same manner by plugins
It could be :
Added snackbar dialog to:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.