Added array to snackbar qml

[ahcorde]

🎉 New feature

Summary

if we start getting too many notifications at once to show in the snackbar, this logic will display them consecutively.

ESC will close the popup, otherwise with the mouse click some of the popup will close inmediately if you are clicking several times to configure something.

Build on top of #369

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #370 (f7daa20) into ign-gui3 (fc2f870) will decrease coverage by 0.13%.
The diff coverage is 38.46%.

❗ Current head f7daa20 differs from pull request most recent head 1b58a8c. Consider uploading reports for the commit 1b58a8c to get more accurate results

@@             Coverage Diff              @@
##           ign-gui3     #370      +/-   ##
============================================
- Coverage     65.96%   65.83%   -0.14%     
============================================
  Files            29       29              
  Lines          3191     3202      +11     
============================================
+ Hits           2105     2108       +3     
- Misses         1086     1094       +8     

Impacted Files	Coverage Δ
include/ignition/gui/MainWindow.hh	100.00% <ø> (ø)
src/plugins/screenshot/Screenshot.cc	30.12% <0.00%> (-3.22%)	⬇️
src/plugins/teleop/Teleop.cc	83.19% <37.50%> (-1.77%)	⬇️
src/plugins/image_display/ImageDisplay.cc	24.07% <66.66%> (+0.80%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14f379...1b58a8c. Read the comment docs.

[ahcorde]

@chapulina

• Added a Dismiss button
• Aligned text
• used bold to highlight some relevant information such as: topics or paths

[chapulina]

Added a Dismiss button

Thanks! I was thinking of making that optional though. Most implementations have buttons as optional, see

• https://www.webcomponents.org/element/@polymer/paper-toast/demo/demo/index.html
• https://material.angular.io/components/snack-bar/overview

Usually the button text is configurable and there's a way to register a callback when the button is clicked. I don't think we need all these features just yet, but it would be good to:

• structure the API in a way that it can be extended later
• the button should be optional for now, so messages that aren't very important have a timeout and can be dismissed by the usual means (like subscription to topics), but messages that are important have a button that must be clicked to dismiss (like a failure to save a file).
• make the button flat like in the implementations above (from the spec "Don’t use a filled or elevated button in a snackbar, as it draws too much attention.")

Aligned text

I think it would be better to follow the spec and align the text to the left like it was already.

[chapulina]

@ahcorde , I have some suggestions on #375, let me know what you think

[chapulina]

Argh, Bionic is broken with

   qrc:/qml/IgnSnackBar.qml:48 Cannot assign to non-existent property "horizontalPadding"

That's something I added on #375. Let me find an alternative

[chapulina]

LGTM once CI comes back ok

[chapulina]

@osrf-jenkins run tests please

[chapulina]

Bionic is happy now, the webhooks have been acting up all day. Merging.

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1