Fix rendering tests #561
Merged
Fix rendering tests #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## fix_tests #561 +/- ##
==========================================
Coverage 70.91% 70.91%
==========================================
Files 45 45
Lines 4941 4941
==========================================
Hits 3504 3504
Misses 1437 1437 |
azeey
approved these changes
Aug 21, 2023
mjcarroll
added a commit
that referenced
this pull request
Aug 22, 2023
* Break scene3d test apart into component tests Signed-off-by: Michael Carroll <[email protected]> * Fix include paths Signed-off-by: Michael Carroll <[email protected]> * Remove scene3d as it is deprecated Signed-off-by: Michael Carroll <[email protected]> * Remove message header Signed-off-by: Michael Carroll <[email protected]> * Bump everything to ogre2 by default Signed-off-by: Michael Carroll <[email protected]> * line order Signed-off-by: Louise Poubel <[email protected]> * Fix tests by delaying get render engine calls (#535) --------- Signed-off-by: Ian Chen <[email protected]> * revert default engine Signed-off-by: Ian Chen <[email protected]> * Fix rendering tests (#561) * debugging Signed-off-by: Ian Chen <[email protected]> * reset cam Signed-off-by: Ian Chen <[email protected]> * more testing Signed-off-by: Ian Chen <[email protected]> * no unload Signed-off-by: Ian Chen <[email protected]> * more testing with no unload Signed-off-by: Ian Chen <[email protected]> * unload engine in gzrenderer Signed-off-by: Ian Chen <[email protected]> * unload engine in gzrenderer debugging Signed-off-by: Ian Chen <[email protected]> * unload engine in gzrenderer reset scene Signed-off-by: Ian Chen <[email protected]> * comment out unload Signed-off-by: Ian Chen <[email protected]> * increase timeout Signed-off-by: Ian Chen <[email protected]> * test timing Signed-off-by: Ian Chen <[email protected]> * cleanup Signed-off-by: Ian Chen <[email protected]> * cleanup Signed-off-by: Ian Chen <[email protected]> * more cleanup Signed-off-by: Ian Chen <[email protected]> --------- Signed-off-by: Ian Chen <[email protected]> * Suppress warnings in metal Signed-off-by: Michael Carroll <[email protected]> * Incorrect args Signed-off-by: Michael Carroll <[email protected]> --------- Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Ian Chen <[email protected]>
2 tasks
I created #565 for this. I'll look into it as a background task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Targeted at #429
Summary
The tests below are still failing on Jammy github actions in #429:
The failing tests were supposed to be fixed by #535 but for some reason they are now happening again.
The "fix" is more of a workaround. The main change is to not unload the render engine on exit which is what's causing the segfault in these 2 tests. It's safe to remove the
DestroyScenecall in the tests as that's taken care of by the minimal scene plugin. The tests do not fail on other CI builds and I'm also not able to reproduce them locally.We could either get this in to make CI green or spend more time finding the root cause of the problem.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.