Transport Topics Plugin

[AmrElsersy]

Topic Viewer Plugin

• Topics Viewer Plugin which lists all ign-transport topics that is currently published.
• Models each topic structure and shows its fields and nested fields
• Plot-able fields are drag-able to be used by the plotting tool

[chapulina]

Looking good, I did an initial review 😉

[claireyywang]

some quick style comments. I'll look more into code logic later.

[chapulina]

I noticed that there's always one item under the topic name with the message type, for example, Pose_V below:

I think we could get rid of that extra level. And just have the field names:

/world/default/dynamic_pose/info
├── header
└── pose

---

Also, just a reminder to make the plottable fields draggable 😉

[AmrElsersy]

@chapulina I solved all style issues you mentioned
and made the items draggable and the tooltip

[chapulina]

This is looking great! A couple more comments:

Right now there's no way to see a topic if it starts being published after the plugin was open. How about updating it periodically like this:

https:/ignitionrobotics/ign-gui/blob/560389770529d50a1b7c925c211ba0967fccd12b/src/plugins/TopicViewer.cc#L371-L374

[claireyywang]

works great in general, just have some comments from debugging the Scene msg

[claireyywang]

Spotted missing topics during debugging recursive messages in Scene
Terminal output

[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: header, msg field type: Header
[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: ambient, msg field type: Color
[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: background, msg field type: Color
[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: sky, msg field type: Sky
[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: fog, msg field type: Fog
[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: model, msg field type: Model
[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: light, msg field type: Light
[GUI] [Dbg] [TopicViewer.cc:197] msg name: Scene, msg field name: joint, msg field type: Joint

Topic viewer

[chapulina]

I did another pass. This is looking really neat! Did you give any thought to the periodic update?

[chapulina]

Did you get a chance to triage these, @AmrElsersy ?

[chapulina]

Left some comments on the test, it's looking pretty good, but I didn't try running it locally.

[claireyywang]

Thanks for adding the test! I did another review. It looks good in general. I just had some nitpicks on style and minor questions.

[claireyywang]

a couple lingering style issue, otherwise looks good to me! Also make sure to git pull before working on local branch, I made some small commits along the way.

[chapulina]

Working for me, great work!

Besides the other comments, the only thing I'd like to ask is that you change all the indentation to be 2 spaces in the QML file. Right now there's a mix of 2 and 4 🙂 Thanks!

[chapulina]

LGTM! I just fixed a linter error on 3071d72.

Also, the new test is failing on CI. This should fix it on Ubuntu: gazebo-tooling/release-tools#255. And for Homebrew, we can disable it when #76 is merged forward.

[claireyywang]

LGTM!

[cottsay]

This appears to have caused a build regression on Windows: https://build.osrfoundation.org/job/ign_gui-ci-win/58/consoleFull#-20872881438ff58640-3599-4406-a210-216932f1748c

FYI @AmrElsersy / @chapulina / @claireyywang

[chapulina]

Thanks, @cottsay , compilation should be fixed on #103 🤞