Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unversioned files lib/ruby/ignition/msgs/*.rb conflict between flavors for different versions #24

Closed
osrf-migration opened this issue Nov 21, 2018 · 9 comments
Labels
bug Something isn't working

Comments

@osrf-migration
Copy link

Original report (archived issue) by yurivict (Bitbucket: yurivict).


They can't be installed together.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Can you add more information? I don't know what the problem is, and how to reproduce it.

@osrf-migration
Copy link
Author

Original comment by yurivict (Bitbucket: yurivict).


On one hand, you allow different versions to be installed at the same time. On the other hand, these files are unversioned, and therefore would cause conflicts if installed by multiple versions.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Are you referring to the protobuf ruby files?

lib/ruby/ignition/msgs/plugin_v_pb.rb
lib/ruby/ignition/msgs/undo_redo_pb.rb
lib/ruby/ignition/msgs/bytes_pb.rb
lib/ruby/ignition/msgs/tactile_pb.rb
lib/ruby/ignition/msgs/diagnostics_pb.rb
lib/ruby/ignition/msgs/subscribe_pb.rb

These are installed only by msgs3 in the gz11 branch.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Issue #27 was marked as a duplicate of this issue.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "new" to "resolved"

Install ruby files into versioned folder, fixes #24

→ <<cset 35ade84>>

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "resolved" to "open"

pull request #109 not yet merged

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "open" to "resolved"

Merged in issue_24 (pull request #109)

Install ruby files into versioned folder, fixes #24

Approved-by: Nate Koenig [email protected]
Approved-by: Louise Poubel [email protected]

→ <<cset d312819>>

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Install ruby files into versioned folder, fixes #24

→ <<cset 35ade84>>

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Merged in issue_24_3 (pull request #111)

backport to msgs3: Install ruby files into versioned folder, fixes #24

Approved-by: Jose Luis Rivero [email protected]
Approved-by: Nate Koenig [email protected]

→ <<cset 268b08f>>

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
j-rivero pushed a commit that referenced this issue Jun 28, 2021
Install ruby files into versioned folder, fixes #24

Approved-by: Nate Koenig <[email protected]>
Approved-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant