Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focal CI: static checkers and doxygen linters #230

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Add cppcheck, cpplint and doxygen checks.

Test it

Focal CI on GitHub actions should return green.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from caguero as a code owner March 11, 2022 22:27
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #230 (cb30517) into ign-msgs5 (8595461) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs5     #230   +/-   ##
==========================================
  Coverage      85.27%   85.27%           
==========================================
  Files              9        9           
  Lines            903      903           
==========================================
  Hits             770      770           
  Misses           133      133           
Impacted Files Coverage Δ
include/ignition/msgs/PointCloudPackedUtils.hh 84.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8595461...cb30517. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 901dd0c into ign-msgs5 Mar 12, 2022
@chapulina chapulina deleted the chapulina/5/ci_checks branch March 12, 2022 00:14
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants