Feature/add visual arrow and axis #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
feature/AddVisualArrowAndAxis
branch
2 times, most recently
from
887b855
to
a5fe0c1
Compare
caguero
reviewed
May 26, 2020
Signed-off-by: Levi Armstrong <[email protected]>
Levi-Armstrong
force-pushed
the
feature/AddVisualArrowAndAxis
branch
from
a5fe0c1
to
98e8c0c
Compare
caguero
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on PR #61.
It adds additional types ARROW and AXIS to both geometry type message and marker type message. This is to allow for the creation of visual arrow and axis scene types with either a visual message or marker message. I assumed only the type is required because position and scale is provided by the visual and maker messages.