4 ➡️ 5 #310
Merged
4 ➡️ 5 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the original test with AddressSanitizer gives stack-use-after-scope. Reference: "C++11 and the auto keyword" https://eigen.tuxfamily.org/dox/TopicPitfalls.html Signed-off-by: Hill Ma <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Adds support for registering callbacks that modify properties of all contacts generated by the dynamics engine. Example implementation for DART is provided. Signed-off-by: Martin Pecka <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
* Added DART feature for setting joint limits dynamically. Signed-off-by: Martin Pecka <[email protected]> * Make code compatible with older DART release (this commit can be reverted once newer DART is out). Signed-off-by: Martin Pecka <[email protected]> * Updated the number of models for test. Signed-off-by: Martin Pecka <[email protected]> * Apply suggestions from code review Signed-off-by: Martin Pecka <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> * Fixed issues from review. Signed-off-by: Martin Pecka <[email protected]> * Accomodate DART 6.9 Signed-off-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
The header template provided by ign-cmake is used instead. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-physics5 #310 +/- ##
================================================
+ Coverage 75.54% 75.73% +0.19%
================================================
Files 127 129 +2
Lines 5655 5762 +107
================================================
+ Hits 4272 4364 +92
- Misses 1383 1398 +15
Continue to review full report at Codecov.
|
azeey
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-physics4toign-physics5Branch comparison: ign-physics5...ign-physics4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸