Suppress MSVC warning that is not applicable #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
8 tasks
mxgrey
approved these changes
Nov 1, 2022
Codecov Report
@@ Coverage Diff @@
## gz-physics6 #446 +/- ##
============================================
Coverage 75.73% 75.73%
============================================
Files 140 140
Lines 7039 7039
============================================
Hits 5331 5331
Misses 1708 1708 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Michael Carroll <[email protected]>
scpeters
approved these changes
Nov 1, 2022
mjcarroll
changed the title
nkoenig
approved these changes
Nov 1, 2022
|
This fix can also be applied to ign-physics5 to fix warnings in ign-gazebo6 to partially resolve gazebosim/gz-sim#2384 @Mergifyio backport ign-physics5 |
|
@Mergifyio backport ign-physics5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Michael Carroll <[email protected]> (cherry picked from commit f2775ac) # Conflicts: # include/gz/physics/FeatureList.hh
azeey
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Michael Carroll <[email protected]> (cherry picked from commit f2775ac) Signed-off-by: Addisu Z. Taddese <[email protected]>
iche033
pushed a commit
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit f2775ac) Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers a warning in downstream libraries such as:
https://build.osrfoundation.org/job/ign_gazebo-pr-win/5195/msbuild/
After talking with @mxgrey, while this is typically a relevant warning by MSVC, it is not applicable so we can suppress it.
Signed-off-by: Michael Carroll [email protected]