Towards Green CI #1771
Merged
Towards Green CI #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1771 +/- ##
===========================================
- Coverage 64.16% 63.81% -0.35%
===========================================
Files 335 336 +1
Lines 26508 27170 +662
===========================================
+ Hits 17008 17339 +331
- Misses 9500 9831 +331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
…rroll/green_build
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
|
Getting much closer here! On Windows we are down to 80 compiler warnings (in various places) and the "HydronamicsTest.VelcoityTestInOil" which has been failing for 70 builds now. On Ubuntu we are down to UNIT_Gui_clean_exit_TEST which segfaults... |
|
I'm trying to reproduce the |
|
I'm thinking that we disable and ticket this HydronamicsTest, I don't see any evidence that it ever worked. |
|
I'm good with that plan |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
I marked it as disabled on Windows. We should be down to the GUI clean exit test and some Windows warnings. |
Signed-off-by: Michael Carroll <[email protected]>
8 tasks
|
Some of these warnings are coming from fuel_tools, addressing those separately here: gazebosim/gz-fuel-tools#308 |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
…gn-gazebo into mjcarroll/green_build
|
Remaining Windows warnings are coming from physics. Addressed via: gazebosim/gz-physics#446 |
|
@osrf-jenkins retest this please |
Signed-off-by: Nate Koenig <[email protected]>
|
Window's warnings are gone. I'm unable to solve the server and gui tests easily, so I'll save those for another PR. |
nkoenig
approved these changes
Nov 2, 2022
9 tasks
Crola1702
added a commit
that referenced
this pull request
Feb 2, 2023
More details: 0a84abe Signed-off-by: Crola1702 <[email protected]>
Crola1702
added a commit
that referenced
this pull request
Feb 3, 2023
Fixes part of #1870 This PR fixes some warnings (C4244 and C4305) happening in ign-gazebo6 windows Reference build: https://build.osrfoundation.org/job/ign_gazebo-ign-6-win/166/ * Fix warning C4244 Signed-off-by: Crola1702 <[email protected]> * Fix warning C4305 Signed-off-by: Crola1702 <[email protected]> * Fix line lenght linter error Signed-off-by: Crola1702 <[email protected]> * Fix linter issues again Signed-off-by: Crola1702 <[email protected]> * Update src/systems/optical_tactile_plugin/OpticalTactilePlugin.cc Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Crola1702 <[email protected]> * Apply PR suggestions Signed-off-by: Crola1702 <[email protected]> * Fix bracket position Signed-off-by: Crola1702 <[email protected]> * Aplly test fix done in gz-sim7 (gz-sim #1771) More details: 0a84abe Signed-off-by: Crola1702 <[email protected]> --------- Signed-off-by: Crola1702 <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
scpeters
added a commit
that referenced
this pull request
Feb 10, 2023
Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Feb 11, 2023
Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fix things that are currently known-bad in CI.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.