Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API to use std::chrono #5

Closed
osrf-migration opened this issue Mar 19, 2019 · 1 comment · Fixed by #41
Closed

Update API to use std::chrono #5

osrf-migration opened this issue Mar 19, 2019 · 1 comment · Fixed by #41
Labels
major proposal

Comments

@osrf-migration
Copy link

Original report (archived issue) by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).

Summary

The sensor Update function currently accepts common::Time. We should consider either changing them to accept std::chrono through tick-tock cycle or adding new overloaded Update function in addition to the existing ones.

Motivation

std::chrono is now a widely accepted time and date library and it's also used in other ignition projects.

Describe alternatives you've considered

N/A
@chapulina
Copy link
Contributor

Related to gazebosim/gz-common#61

@ahcorde ahcorde linked a pull request Sep 4, 2020 that will close this issue
Replaced common::Time for std::chrono #41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced common::Time for std::chrono gazebosim/gz-sensors
2 participants
@chapulina @osrf-migration