Replaced common::Time for std::chrono

[ahcorde]

This PR is part of this issue gazebosim/gz-common#61. The idea it's to deprecate the class common::Time in favor of std::chrono.

Related with gazebosim/gz-common#90

Signed-off-by: ahcorde [email protected]

[iche033]

hmm I think we should follow the tick-tock release cycle and deprecate the functions in Dome first then remove them in ignition E

[scpeters]

it could be nice to add a helper function to ign-msgs that populates msgs::Time from std::chrono::system_clock::time_point. it could be another Convert(...) function in ignition/msgs/Utility.hh

[chapulina]

it could be nice to add a helper function to ign-msgs that populates msgs::Time from std::chrono::system_clock::time_point

We already have some in ignition/math/Helpers.hh, so I'd suggest we add more there too.

[codecov]

Codecov Report

Merging #41 into master will decrease coverage by 1.34%.
The diff coverage is 54.41%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   77.67%   76.32%   -1.35%     
==========================================
  Files          23       23              
  Lines        2302     2319      +17     
==========================================
- Hits         1788     1770      -18     
- Misses        514      549      +35     

Impacted Files	Coverage Δ
include/ignition/sensors/Manager.hh	90.00% <ø> (ø)
src/Sensor.cc	88.29% <25.00%> (-4.97%)	⬇️
src/Manager.cc	75.00% <33.33%> (-6.09%)	⬇️
src/Lidar.cc	72.82% <42.85%> (-1.90%)	⬇️
src/AirPressureSensor.cc	83.33% <50.00%> (-2.59%)	⬇️
src/AltimeterSensor.cc	86.04% <50.00%> (-2.19%)	⬇️
src/CameraSensor.cc	73.35% <50.00%> (-1.56%)	⬇️
src/LogicalCameraSensor.cc	87.14% <50.00%> (-2.72%)	⬇️
src/MagnetometerSensor.cc	86.20% <50.00%> (-2.17%)	⬇️
src/ImuSensor.cc	88.46% <66.66%> (-1.74%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57b75e...5968527. Read the comment docs.

[ahcorde]

I can see some Ogre errors:

22: unknown file: Failure
22: C++ exception with description "OGRE EXCEPTION(2:InvalidParametersException): All framebuffer formats with this texture internal format unsupported in GL3PlusFrameBufferObject::initialise at /var/lib/jenkins/workspace/ogre-2.1-debbuilder/repo/RenderSystems/GL3Plus/src/OgreGL3PlusFrameBufferObject.cpp (line 229)" thrown in the test body.

@iche033 any thoughts?

[iche033]

I started seeing those errors happening recently on our r2d2 jenkins machine. For other PRs, I just take it offline and rerun the build so the tests are run on a different machine.

cc current build farmer @caguero

[chapulina]

The public functions need to be deprecated. Be sure to add a note to the migration guide too. We don't usually test the deprecated functions so I think the tests can remain as they are.

[chapulina]

Still missing some deprecations, but I think we're very close

[chapulina]

I just have the 2 minor comments below that I'll commit now. Then wait for CI and merge.

CC @iche033