Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring point size in Visualize Lidar GUI plugin #1021

Merged
merged 8 commits into from
Oct 6, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 9, 2021

🎉 New feature

depends on gazebosim/gz-rendering#392

Summary

Added a spin box for configuring size of lidar point visualization in Visualize Lidar plugin. Note it only affects Point visualization type. Works for ogre and ogre2 render engine.

Test it

  1. Launch an example world with gpu ray sensor, e.g.:

    ign gazebo -v 4 gpu_lidar_sensor.sdf
    
  2. Open the Visualize Lidar GUI plugin by going to the top right menu (3 vertical dots), scroll down and click on Visualize Lidar.

  3. Unpause the simulation by hitting the play button

  4. Refresh the topic drop down list and select the /lidar topic

  5. Select Points Visual Type to see the default point visualization with size 1

  6. Change Point Size to 5 and hit Enter to see larger points.

lidar_point_size

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 9, 2021
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Sep 10, 2021
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor style fix

src/gui/plugins/visualize_lidar/VisualizeLidar.qml Outdated Show resolved Hide resolved
@ahcorde
Copy link
Contributor

ahcorde commented Sep 14, 2021

cpplint is failing. Fixed here #1025

@nkoenig nkoenig changed the base branch from main to ign-gazebo6 October 4, 2021 20:02
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #1021 (1d7a8f5) into ign-gazebo6 (447e5c2) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 1d7a8f5 differs from pull request most recent head b6a379a. Consider uploading reports for the commit b6a379a to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1021      +/-   ##
===============================================
- Coverage        64.07%   64.04%   -0.03%     
===============================================
  Files              255      255              
  Lines            20051    20051              
===============================================
- Hits             12847    12841       -6     
- Misses            7204     7210       +6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 92.91% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 447e5c2...b6a379a. Read the comment docs.

@iche033 iche033 merged commit c603710 into ign-gazebo6 Oct 6, 2021
@iche033 iche033 deleted the lidar_point_size branch October 6, 2021 18:34
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Oct 8, 2021
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
…azebosim#1021)

* add spinbox to configure point size

Signed-off-by: Ian Chen <[email protected]>

* cap letter

Signed-off-by: Ian Chen <[email protected]>

* remove empty line

Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants