Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view angle linters #1025

Closed
wants to merge 1 commit into from
Closed

Fix view angle linters #1025

wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 14, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Fixes linter in view angle

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #1025 (daeed3a) into main (e3ee0af) will decrease coverage by 1.22%.
The diff coverage is 49.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   64.66%   63.43%   -1.23%     
==========================================
  Files         242      238       -4     
  Lines       19014    19398     +384     
==========================================
+ Hits        12296    12306      +10     
- Misses       6718     7092     +374     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
include/ignition/gazebo/rendering/RenderUtil.hh 100.00% <ø> (ø)
include/ignition/gazebo/rendering/SceneManager.hh 100.00% <ø> (ø)
src/SdfEntityCreator.cc 84.53% <0.00%> (-0.89%) ⬇️
src/gui/Gui.cc 65.35% <ø> (+0.23%) ⬆️
src/gui/GuiRunner.cc 85.91% <0.00%> (-0.34%) ⬇️
src/gui/plugins/scene3d/Scene3D.hh 50.00% <ø> (ø)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899034b...daeed3a. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working labels Sep 14, 2021
@chapulina
Copy link
Contributor

Thanks for the PR, but it was already fixed in #1020

@chapulina chapulina closed this Sep 14, 2021
@chapulina chapulina deleted the ahcorde/fix/view_angle branch September 14, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants