Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 ➡️ 5 #1259

Merged
merged 10 commits into from
Dec 21, 2021
Merged

4 ➡️ 5 #1259

merged 10 commits into from
Dec 21, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo4 to ign-gazebo5

Branch comparison: ign-gazebo5...ign-gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey and others added 9 commits November 15, 2021 18:03
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Support battery draining start via topics

Signed-off-by: Nate Koenig <[email protected]>

* Added more documentation and a todo item

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
* Make tests run as fast as possible (#1194)

Signed-off-by: Louise Poubel <[email protected]>

* [Dome] Make tests run as fast as possible (#1250)

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #1259 (3c4892b) into ign-gazebo5 (a06198f) will increase coverage by 0.27%.
The diff coverage is 94.73%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5    #1259      +/-   ##
===============================================
+ Coverage        65.99%   66.26%   +0.27%     
===============================================
  Files              255      255              
  Lines            20137    20153      +16     
===============================================
+ Hits             13289    13355      +66     
+ Misses            6848     6798      -50     
Impacted Files Coverage Δ
src/systems/battery_plugin/LinearBatteryPlugin.cc 63.01% <93.33%> (+21.98%) ⬆️
src/SimulationRunner.cc 93.92% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06198f...3c4892b. Read the comment docs.

@chapulina chapulina merged commit 1780d5f into ign-gazebo5 Dec 21, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch December 21, 2021 18:41
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants