Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused View::Clone method #1440

Merged
merged 1 commit into from
Apr 12, 2022
Merged

remove unused View::Clone method #1440

merged 1 commit into from
Apr 12, 2022

Conversation

adlarkin
Copy link
Contributor

Signed-off-by: Ashton Larkin [email protected]

Summary

A method for cloning views was added in #1249, but it turns out that this method actually isn't needed. This PR removes the unused methods.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@adlarkin adlarkin changed the title remove unused View::Clone method remove unused View::Clone method Apr 12, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1440 (5d2dae3) into main (a5464eb) will decrease coverage by 26.98%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1440       +/-   ##
===========================================
- Coverage   62.37%   35.39%   -26.99%     
===========================================
  Files         317       43      -274     
  Lines       24489     2331    -22158     
===========================================
- Hits        15276      825    -14451     
+ Misses       9213     1506     -7707     
Impacted Files Coverage Δ
include/ignition/gazebo/detail/BaseView.hh
include/ignition/gazebo/detail/View.hh
...ems/collada_world_exporter/ColladaWorldExporter.cc
...de/ignition/gazebo/components/ContactSensorData.hh
src/gui/GuiRunner.cc
src/systems/log/LogRecord.cc
...ems/kinetic_energy_monitor/KineticEnergyMonitor.cc
.../gui/plugins/transform_control/TransformControl.cc
...ude/ignition/gazebo/components/TemperatureRange.hh
src/systems/joint_controller/JointController.hh
... and 350 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f2bbd...5d2dae3. Read the comment docs.

@adlarkin adlarkin merged commit b2549dd into main Apr 12, 2022
@adlarkin adlarkin deleted the adlarkin/remove_view_clone branch April 12, 2022 22:01
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants