Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused View::Clone method #1440

Merged
merged 1 commit into from
Apr 12, 2022
Merged

remove unused View::Clone method #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/ignition/gazebo/detail/BaseView.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,6 @@ class IGNITION_GAZEBO_VISIBLE BaseView
/// \sa ToAddEntities
public: void ClearToAddEntities();

public: virtual std::unique_ptr<BaseView> Clone() const = 0;

// TODO(adlarkin) make this a std::unordered_set for better performance.
// We need to make sure nothing else depends on the ordered preserved by
// std::set first
Expand Down
9 changes: 0 additions & 9 deletions include/ignition/gazebo/detail/View.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ class View : public BaseView
/// \brief Documentation inherited
public: void Reset() override;

public: std::unique_ptr<BaseView> Clone() const override;

/// \brief A map of entities to their component data. Since tuples are defined
/// at compile time, we need separate containers that have tuples for both
/// non-const and const component pointers (calls to ECM::Each can have a
Expand Down Expand Up @@ -332,13 +330,6 @@ void View<ComponentTypeTs...>::Reset()
this->invalidConstData.clear();
this->missingCompTracker.clear();
}

//////////////////////////////////////////////////
template<typename ...ComponentTypeTs>
std::unique_ptr<BaseView> View<ComponentTypeTs...>::Clone() const
{
return std::make_unique<View<ComponentTypeTs...>>(*this);
}
} // namespace detail
} // namespace IGNITION_GAZEBO_VERSION_NAMESPACE
} // namespace gazebo
Expand Down