Remove actors from screen when they are supposed to #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils. Signed-off-by: Arjo Chakravarty <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1697 +/- ##
==========================================
Coverage ? 63.88%
==========================================
Files ? 334
Lines ? 26346
Branches ? 0
==========================================
Hits ? 16831
Misses ? 9515
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Sep 12, 2022
Can you go ahead and target this to the earlier version and we can get it on a forward port? |
8 tasks
arjo129
added a commit
that referenced
this pull request
Sep 14, 2022
# 🦟 Bug fix Supercedes #1697. Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created. Fixes #<NUMBER> ## Summary Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils. ## Before  ## After  ## Notes: Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes? Signed-off-by: Arjo Chakravarty <[email protected]>
nkoenig
added a commit
that referenced
this pull request
Nov 3, 2022
* 🎈 3.14.0~pre1 (#1650) Signed-off-by: Louise Poubel <[email protected]> * Remove redundant namespace references (#1635) Signed-off-by: methylDragon <[email protected]> * 🎈 3.14.0 (#1657) Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Louise Poubel <[email protected]> * readd namespaces for Q_ARGS (#1670) * Remove actors from screen when they are supposed to (#1699) # 🦟 Bug fix Supercedes #1697. Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created. Fixes #<NUMBER> ## Summary Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils. ## Before  ## After  ## Notes: Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes? Signed-off-by: Arjo Chakravarty <[email protected]> * Update examples to use gazebosim.org Signed-off-by: Nate Koenig <[email protected]> * Citadel: Removed warnings (#1753) Signed-off-by: ahcorde <[email protected]> * Added collection name to About Dialog (#1756) Signed-off-by: ahcorde <[email protected]> * Convert ignitionrobotics to gazebosim in tests directory (#1757) * Convert ignitionrobotics to gaazebosim in tests directory Signed-off-by: Nate Koenig <[email protected]> * fix gz-gazebo Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Convert ignitionrobotics to gazebosim in sources and includes (#1758) Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Convert ignitionrobotics to gazebosim in tutorials (#1759) Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Final update of ignitionrobotics to gazebosim for citadel (#1760) Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * remove PlotIcon (#1658) Signed-off-by: youhy <[email protected]> Signed-off-by: youhy <[email protected]> * Fix UNIT_ign_TEST Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: methylDragon <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: ahcorde <[email protected]> Signed-off-by: youhy <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: methylDragon <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: AzulRadio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils.
Before
After
Notes:
Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all.
Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes?
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.