Remove actors from screen when they are supposed to

[arjo129]

🦟 Bug fix

Supercedes #1697. Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created.

Fixes #

Summary

Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils.

Before

After

Notes:

Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all.
Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes?

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #1699 (2e18af8) into ign-gazebo3 (3ff727e) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo3    #1699   +/-   ##
============================================
  Coverage        77.98%   77.98%           
============================================
  Files              255      255           
  Lines            15041    15041           
============================================
  Hits             11729    11729           
  Misses            3312     3312           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[iche033]

looks like the SceneManager::CreateActor function adds an the entity to various actor maps, i.e. actors here, actorSkeletons here, and actorTrajectories here. Can you also update SceneManager::RemoveEntity function to also remove the entity from those maps in addition to visuals?

[arjo129]

Addressed in 2e18af8

looks like the SceneManager::CreateActor function adds an the entity to various actor maps, i.e. actors here, actorSkeletons here, and actorTrajectories here. Can you also update SceneManager::RemoveEntity function to also remove the entity from those maps in addition to visuals?