Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view angle plugin #1877

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Fix view angle plugin #1877

merged 2 commits into from
Feb 6, 2023

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Summary

Replaced IgnSpinBox with GzSpinBox, which was causing the plugin to fail to load. Also adjusted the minimumHeight to correctly view all contents and replaced ignmsg/err with gzmsg/err.

Before updating minimumHeight:
before

After:
after

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 31, 2023
@jennuine jennuine self-assigned this Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1877 (d38866c) into gz-sim7 (af73ebe) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head d38866c differs from pull request most recent head 2ea163b. Consider uploading reports for the commit 2ea163b to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1877      +/-   ##
===========================================
+ Coverage    64.64%   64.69%   +0.04%     
===========================================
  Files          343      343              
  Lines        27542    27542              
===========================================
+ Hits         17805    17817      +12     
+ Misses        9737     9725      -12     
Impacted Files Coverage Δ
src/SimulationRunner.cc 92.15% <0.00%> (+1.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033
Copy link
Contributor

iche033 commented Jan 31, 2023

@j-rivero or @caguero, gz-sim ubuntu builds are failing in garden and harmonic and complains about errors processing gz-transport 12 nightlies. Do you think it's related to gazebo-tooling/release-tools#872 or gazebo-tooling/release-tools#873?

@iche033
Copy link
Contributor

iche033 commented Jan 31, 2023

Changes look good. Just need to get CI green

src/gui/plugins/view_angle/ViewAngle.cc Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from ahcorde February 3, 2023 23:44
@ahcorde ahcorde merged commit a274c8a into gz-sim7 Feb 6, 2023
@ahcorde ahcorde deleted the jennuine/view_angle_fix branch February 6, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants