Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake unrecognized argument warning #1882

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 2, 2023

🦟 Bug fix

Summary

The following warning was caused by a missing VERSION flag

  The build script has specified some unrecognized arguments for
  gz_find_package(~):

  12.1

  Either the script has a typo, or it is using an unexpected version of
  gz-cmake.  The version of gz-cmake currently being used is 3.0.1

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The following warning was caused by a missing `VERSION` flag
```
  The build script has specified some unrecognized arguments for
  gz_find_package(~):

  12.1

  Either the script has a typo, or it is using an unexpected version of
  gz-cmake.  The version of gz-cmake currently being used is 3.0.1

```

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mjcarroll as a code owner February 2, 2023 23:43
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #1882 (d1961ac) into gz-sim7 (5d35c5a) will not change coverage.
The diff coverage is n/a.

❗ Current head d1961ac differs from pull request most recent head 296b301. Consider uploading reports for the commit 296b301 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #1882   +/-   ##
========================================
  Coverage    64.57%   64.57%           
========================================
  Files          344      344           
  Lines        27578    27578           
========================================
  Hits         17808    17808           
  Misses        9770     9770           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit b7a08cd into gazebosim:gz-sim7 Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants