Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minor issue in the documentation of the server API #2067

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Aug 2, 2023

🦟 Bug fix

Fixes an inconsistency in the server API documentation where types of services aren't correctly named.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@arjo129 arjo129 requested a review from mjcarroll as a code owner August 2, 2023 05:28
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2067 (dd532ff) into ign-gazebo3 (4587827) will not change coverage.
The diff coverage is n/a.

❗ Current head dd532ff differs from pull request most recent head 486c230. Consider uploading reports for the commit 486c230 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo3    #2067   +/-   ##
============================================
  Coverage        70.77%   70.77%           
============================================
  Files              262      262           
  Lines            16763    16763           
============================================
  Hits             11864    11864           
  Misses            4899     4899           
Files Changed Coverage Δ
include/gz/sim/Server.hh 100.00% <ø> (ø)

@arjo129 arjo129 merged commit 4d31281 into ign-gazebo3 Aug 2, 2023
5 checks passed
@arjo129 arjo129 deleted the arjo/docs/update_server_info_types branch August 2, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants