Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simulation world with large number of entities #283

Merged
merged 6 commits into from
Aug 13, 2020
Merged

Add simulation world with large number of entities #283

merged 6 commits into from
Aug 13, 2020

Conversation

claireyywang
Copy link
Contributor

@claireyywang claireyywang commented Aug 12, 2020 •
edited
Loading

This PR add both the erb template file and the generated .sdf file.

To generate .sdf file, use

erb -T 1 actors_population.sdf.erb > actors_population.sdf

Used in gazebosim/gz-physics#93

@claireyywang claireyywang self-assigned this Aug 12, 2020
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 12, 2020
@claireyywang
add end of line
73b4da7 
Signed-off-by: claireyywang <[email protected]>
@claireyywang claireyywang mentioned this pull request Aug 12, 2020
Merged
iche033
iche033 reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just some minor comments

examples/worlds/actors_population.sdf.erb Outdated Show resolved Hide resolved
examples/worlds/shapes_population.sdf.erb Outdated Show resolved Hide resolved
examples/worlds/actors_population.sdf.erb Outdated Show resolved Hide resolved
examples/worlds/actors_population.sdf.erb Outdated Show resolved Hide resolved
examples/worlds/actors_population.sdf.erb Outdated Show resolved Hide resolved
@claireyywang
address review comments
fe5e5c4 
Signed-off-by: claireyywang <[email protected]>
chapulina
chapulina approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supposedly, our command line should parse ERB files on this line:

https:/ignitionrobotics/ign-gazebo/blob/8ec8d66cc8a6b661a2db6ccae153a785287fa315/src/cmd/cmdgazebo.rb.in#L351-L352

But this is not going well for these 2 examples. I think this is a problem on the ruby code rather than the SDF files though.

@chapulina chapulina merged commit e41be3a into ign-gazebo3 Aug 13, 2020
@chapulina chapulina deleted the claire/performance-benchmarking branch August 13, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@chapulina chapulina chapulina approved these changes

Assignees

@claireyywang claireyywang

Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claireyywang @iche033 @chapulina